Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix code style issues #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2017
Merged

Conversation

StephenOrJames
Copy link
Contributor

This should resolve #53.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 28, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 28, 2017

CLA assistant check
All committers have signed the CLA.

@mbernier
Copy link
Contributor

mbernier commented Nov 3, 2017

@StephenOrJames

We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.

Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)

You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!

Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.

@StephenOrJames
Copy link
Contributor Author

@mbernier

Sorry about the delayed response - it's been a busy weekend, but I did in fact submit the form in time. Thanks for being awesome!

@mbernier mbernier added difficulty: medium fix is medium in difficulty and removed difficulty: easy fix is easy in difficulty labels Nov 17, 2017
@mbernier mbernier merged commit 3fdd4e5 into sendgrid:master Nov 17, 2017
@thinkingserious
Copy link
Contributor

Hello @StephenOrJames,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@mbernier
Copy link
Contributor

If you are interested, we would love the opportunity to talk to you about Hacktoberfest and our API libraries.

Our agenda would be: Explore what you liked and is there anything we can do to improve?

You can grab a time on my calendar that works for you and we can have a chat on Google Hangout or Skype. If you prefer, you can email me using my GitHub username at my company’s domain.

Thank you so much,

Matt Bernier - @mbernier - SendGrid Developer Experience Product Manager
Elmer Thomas - @thinkingserious - SendGrid Developer Experience Engineer
@sendgrid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CodeClimate report shows some quick fixes that can be done.
5 participants