Adds test for repo files #60
Conversation
tests/test_repofiles.py
Outdated
| return any(map(path.isfile, files)) | ||
|
|
||
| def test_file_existance(self): | ||
| self.assertTrue(all(map(self._any_file, self.FILES))) |
There was a problem hiding this comment.
Can you please have this report an error about which file was failing when it fails? Right now, we just know THAT it failed, not why.
Bug: test does the opposite and fails when files are all found. Now reports the missing files.
|
@cheukyin699 We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt. Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!) You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged. |
|
Hello @cheukyin699, |
|
If you are interested, we would love the opportunity to talk to you about Hacktoberfest and our API libraries. Our agenda would be: Explore what you liked and is there anything we can do to improve? You can grab a time on my calendar that works for you and we can have a chat on Google Hangout or Skype. If you prefer, you can email me using my GitHub username at my company’s domain. Thank you so much, Matt Bernier - @mbernier - SendGrid Developer Experience Product Manager |
This should resolve #58. Does not pass tests because of missing files.