Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix travis build errors #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 22, 2018
Merged

Fix travis build errors #83

merged 3 commits into from
May 22, 2018

Conversation

delirious-lettuce
Copy link
Contributor

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

Changing the copyright year in LICENSE.txt from 2017 -> 2018 fixes one of the two current Travis build errors.

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jan 8, 2018
@codecov
Copy link

codecov bot commented Jan 8, 2018 •
edited
Loading

Codecov Report

Merging #83 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #83   +/-   ##
=======================================
  Coverage   92.22%   92.22%           
=======================================
  Files           6        6           
  Lines         296      296           
=======================================
  Hits          273      273           
  Misses         23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 969b515...cdb00f6. Read the comment docs.

@delirious-lettuce delirious-lettuce changed the title Update year in LICENSE.txt from 2017 -> 2018 (fix a Travis build error) Fix travis build errors Jan 8, 2018
@delirious-lettuce
Copy link
Contributor Author

delirious-lettuce commented Jan 8, 2018 •
edited
Loading

I just went and found an example USE_CASES.md from another SendGrid repo and created a stub for this repo.

https://github.com/sendgrid/sendgrid-php/blob/master/USE_CASES.md

Creating this file and updating the year fixes both travis build errors. I'm not sure if simply creating this file fixes #78 but it's a start!

@thinkingserious
Copy link
Contributor

Awesome, thanks @delirious-lettuce!

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jan 12, 2018
@thinkingserious thinkingserious added type: bug bug in the library difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code labels Feb 27, 2018
@thinkingserious thinkingserious merged commit 32077e3 into sendgrid:master May 22, 2018
@thinkingserious
Copy link
Contributor

Hello @delirious-lettuce,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio type: bug bug in the library type: docs update documentation change not affecting the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delirious-lettuce @thinkingserious