Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add manifest that includes the license in sdist #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2018
Merged

Add manifest that includes the license in sdist #87

merged 1 commit into from
May 22, 2018

Conversation

RohitK89
Copy link
Contributor

@RohitK89 RohitK89 commented May 18, 2018 •
edited
Loading

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Adds a manifest so that the license file exists in the Pypi tar ball

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label May 18, 2018
@SendGridDX
Copy link

SendGridDX commented May 18, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@thinkingserious
Copy link
Contributor

Thanks @RohitK89,

This is now on our backlog for review and merge.

@thinkingserious
Copy link
Contributor

Hello @RohitK89,

Thanks again for taking the time to make a PR.

Why do you think we need a Manifest.in file? According to this thread, it seems like it's not needed.

With Best Regards,

Elmer

@thinkingserious thinkingserious added status: waiting for feedback waiting for feedback from the submitter and removed status: code review request requesting a community code review or review from Twilio labels May 22, 2018
@RohitK89
Copy link
Contributor Author

RohitK89 commented May 22, 2018 via email

@thinkingserious
Copy link
Contributor

Sounds good, thanks!

@thinkingserious thinkingserious merged commit 8a15c76 into sendgrid:master May 22, 2018
@thinkingserious
Copy link
Contributor

Hello @RohitK89,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: waiting for feedback waiting for feedback from the submitter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RohitK89 @SendGridDX @thinkingserious