Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test: Issue#40 unittest to check for specific repo files #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 1, 2017
Merged

test: Issue#40 unittest to check for specific repo files #42

merged 5 commits into from
Nov 1, 2017

Conversation

bertuss
Copy link
Contributor

@bertuss bertuss commented Oct 28, 2017

Fixes #40

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

Adds unit test to check that the list of required files exist in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 28, 2017
@mbernier mbernier added difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 28, 2017
mbernier
mbernier suggested changes Oct 28, 2017
View reviewed changes
Copy link
Contributor

@mbernier mbernier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there's an error when this test is run:

======================================================================
ERROR: test_repository_files_exists (__main__.TestRepository)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/__init__.py", line 107, in test_repository_files_exists
    msg=self.file_not_found_message.format('" or "'.join(file_path)))
ValueError: zero length field name in format

Can you please give this a look?

@bertuss
Copy link
Contributor Author

bertuss commented Oct 29, 2017

Sorry about that, was expecting Travis to error out, so I didn't double check all the errors.
Python 2.6 required an index when using format. Working as expected now.

Docker->Dockerfile
d56d3f0 
This was my fault - my apologies
@SendGridDX
Copy link

SendGridDX commented Oct 31, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mbernier
Copy link
Contributor

mbernier commented Nov 1, 2017

Thanks for making that change!!

@mbernier mbernier merged commit b980bfe into sendgrid:master Nov 1, 2017
@thinkingserious
Copy link
Contributor

Hello @bertuss,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@bertuss bertuss deleted the issue#40-unittest-to-check-for-specific-repo-files branch November 1, 2017 09:15
@geomars geomars mentioned this pull request Nov 1, 2017
Merged
6 tasks
@eshanholtz eshanholtz changed the title Issue#40 unittest to check for specific repo files test: Issue#40 unittest to check for specific repo files Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mbernier mbernier mbernier requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add unittest to check for specific repo files
5 participants
@bertuss @SendGridDX @mbernier @thinkingserious @apigirl