Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: Follows PEP8 standard #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

chore: Follows PEP8 standard #50

wants to merge 6 commits into from

Conversation

Madhur96
Copy link

Fixes #49

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Follows PEP8 standards

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 30, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 30, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Madhur96
Copy link
Author

Madhur96 commented Nov 2, 2017 •
edited
Loading

@ksigler7 please review.
Can you help me with this issue File "./.codeclimate.yml" does not exist in repo!

@thinkingserious
Copy link
Contributor

Hi @Madhur96,

I think you will need to add a file similar to this one at the root level.

With Best Regards,

Elmer

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap difficulty: medium fix is medium in difficulty status: waiting for feedback waiting for feedback from the submitter and removed status: code review request requesting a community code review or review from Twilio labels Feb 27, 2018
@thinkingserious
Copy link
Contributor

Hi @Madhur96,

Could you please resolve the merge conflicts?

Thanks!

With Best Regards,l

Elmer

@hugovk hugovk mentioned this pull request Oct 20, 2018
Merged
4 tasks
@childish-sambino childish-sambino removed the type: community enhancement feature request not on Twilio's roadmap label Jul 20, 2020
@thinkingserious thinkingserious changed the base branch from master to main July 28, 2020 14:37
@thinkingserious thinkingserious changed the title Follows PEP8 standard chore: Follows PEP8 standard Nov 19, 2020
@thinkingserious
Copy link
Contributor

Hello @Madhur96,

We have a few more errors to resolve before this can be merged. Would you please take a look?

Thank you!

With best regards,

Elmer

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap and removed difficulty: medium fix is medium in difficulty labels Nov 19, 2020
@thinkingserious
Copy link
Contributor

Closing until PR feedback is addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: waiting for feedback waiting for feedback from the submitter type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make smtpapi-python follow PEP8 standards
5 participants
@Madhur96 @SendGridDX @thinkingserious @apigirl @childish-sambino