Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: Fix "Complexity" issue in examples/example.py #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2018
Merged

chore: Fix "Complexity" issue in examples/example.py #65

merged 1 commit into from
Oct 22, 2018

Conversation

thepriefy
Copy link
Contributor

@thepriefy thepriefy commented Dec 15, 2017 •
edited
Loading

Fixes #64

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Dec 15, 2017
@thepriefy
Copy link
Contributor Author

I edited all lines which has an error except the line 22, 37, 40 and 43 (the line is too long).
Do I have to fix that too?
Also, I don't know why the travis failed. If there is something I need to fix, please tell me. :)

@thinkingserious
Copy link
Contributor

Hi @thepriefy,

It would be good to fix the line is too long errors using this method.

The Travis failures are not related to your PR, please ignore.

With Best Regards,

Elmer

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty type: community enhancement feature request not on Twilio's roadmap status: waiting for feedback waiting for feedback from the submitter and removed status: code review request requesting a community code review or review from Twilio labels Feb 27, 2018
@misterdorm misterdorm mentioned this pull request Oct 11, 2018
Closed
6 tasks
@thinkingserious thinkingserious merged commit 1d22d35 into sendgrid:master Oct 22, 2018
@thinkingserious
Copy link
Contributor

Hello @thepriefy,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@eshanholtz eshanholtz changed the title Fix "Complexity" issue in examples/example.py chore: Fix "Complexity" issue in examples/example.py Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: waiting for feedback waiting for feedback from the submitter type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix "Complexity" issue in examples/example.py
2 participants
@thepriefy @thinkingserious