Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: fixed Travis, converted README and version as file #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2018
Merged

fix: fixed Travis, converted README and version as file #75

merged 1 commit into from
Oct 12, 2018

Conversation

StrikerRUS
Copy link
Contributor

@StrikerRUS StrikerRUS commented Oct 9, 2018 •
edited
Loading

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • [n/a] I have added necessary documentation about the functionality in the appropriate .md file
  • [n/a] I have added in line documentation to the code I modified

Short description of what this PR does:

  • fix tests and coverage by removing the check of existence of USE_CASES.md
  • add standard __version__ attribute to the package. This attribute is read from the VERSION.txt file, so in the future version should be incremented only in the file.
  • convert README.md to README.rst (appearance can be checked in this branch https://github.com/StrikerRUS/smtpapi-python/blob/pypi/README.rst).
  • add Python versions badge.
    https://img.shields.io/pypi/v/smtpapi.svg
  • add PyPI version badge with appropriate classifiers.
    https://img.shields.io/pypi/pyversions/smtpapi.svg

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 9, 2018
@codecov
Copy link

codecov bot commented Oct 9, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@ee2b073). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #75   +/-   ##
=========================================
  Coverage          ?   99.32%           
=========================================
  Files             ?        2           
  Lines             ?      149           
  Branches          ?        0           
=========================================
  Hits              ?      148           
  Misses            ?        1           
  Partials          ?        0
Impacted Files Coverage Δ
test/__init__.py 100% <ø> (ø)
smtpapi/__init__.py 98.71% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee2b073...7b6fcfd. Read the comment docs.

This was referenced Oct 9, 2018
Closed
Merged
@misterdorm misterdorm added status: work in progress Twilio or the community is in the process of implementing and removed status: code review request requesting a community code review or review from Twilio labels Oct 11, 2018
@misterdorm misterdorm mentioned this pull request Oct 11, 2018
Merged
6 tasks
@daniloff200
Copy link
Contributor

I think, we need this PR to get merged asap!

@misterdorm misterdorm mentioned this pull request Oct 11, 2018
Closed
6 tasks
@daniloff200 daniloff200 mentioned this pull request Oct 11, 2018
Merged
6 tasks
@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap difficulty: medium fix is medium in difficulty hacktoberfest status: ready for deploy code ready to be released in next deploy and removed status: work in progress Twilio or the community is in the process of implementing labels Oct 12, 2018
@thinkingserious
Copy link
Contributor

Hello @StrikerRUS,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious merged commit a7a0e80 into sendgrid:master Oct 12, 2018
@eshanholtz eshanholtz changed the title fixed Travis, converted README and version as file fix: fixed Travis, converted README and version as file Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misterdorm misterdorm misterdorm approved these changes

Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: ready for deploy code ready to be released in next deploy type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@StrikerRUS @daniloff200 @thinkingserious @misterdorm