Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs: add first-timers.md with guide for newcomers #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2018
Merged

docs: add first-timers.md with guide for newcomers #77

merged 1 commit into from
Oct 22, 2018

Conversation

daniloff200
Copy link
Contributor

Closes #73

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

This PR adds a First Timers.MD with a guideline for newcomers

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 11, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 11, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@daniloff200
Copy link
Contributor Author

I see, that Travis build failed, waiting for #75 to be merged.

@codecov
Copy link

codecov bot commented Oct 12, 2018 •
edited
Loading

Codecov Report

Merging #77 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #77   +/-   ##
=======================================
  Coverage   99.32%   99.32%           
=======================================
  Files           2        2           
  Lines         149      149           
=======================================
  Hits          148      148           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7a0e80...3ea7c4b. Read the comment docs.

@devchas devchas added difficulty: medium fix is medium in difficulty hacktoberfest status: work in progress Twilio or the community is in the process of implementing type: docs update documentation change not affecting the code labels Oct 17, 2018
@daniloff200
Copy link
Contributor Author

Hey @thinkingserious ! Are you able and have time to review and merge this PR ?

@thinkingserious thinkingserious added status: ready for deploy code ready to be released in next deploy status: hacktoberfest approved and removed status: code review request requesting a community code review or review from Twilio status: work in progress Twilio or the community is in the process of implementing labels Oct 22, 2018
@thinkingserious
Copy link
Contributor

Hello @daniloff200,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious merged commit 97cca34 into sendgrid:master Oct 22, 2018
@daniloff200 daniloff200 deleted the add-first-timers-md branch October 29, 2018 19:38
@thinkingserious
Copy link
Contributor

Hello @daniloff200,

Thanks again for the PR!

You have earned 17 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at [email protected].

Thank you and Happy Hacktobering!

Team SendGrid

@eshanholtz eshanholtz changed the title add first-timers.md with guide for newcomers docs: add first-timers.md with guide for newcomers Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: ready for deploy code ready to be released in next deploy type: docs update documentation change not affecting the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create first time contributor documentation
4 participants
@daniloff200 @SendGridDX @thinkingserious @devchas