Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Drop support for EOL Python 2.6 #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Drop support for EOL Python 2.6 #83

wants to merge 3 commits into from

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Oct 20, 2018

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Python 2.6 is EOL since 2013-10-29 and no longer receiving security updates (or any updates) from the core Python team
  • It's also little used. Here's this project's PyPI downloads for last month:
category percent downloads
2.7 75.54% 29,551
3.6 11.26% 4,406
3.4 6.32% 2,471
3.5 4.99% 1,954
2.6 0.97% 381
3.7 0.52% 205
3.3 0.28% 108
null 0.12% 45
Total 39,121

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 20, 2018
@codecov
Copy link

codecov bot commented Oct 20, 2018 •
edited
Loading

Codecov Report

Merging #83 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #83   +/-   ##
=======================================
  Coverage   99.32%   99.32%           
=======================================
  Files           2        2           
  Lines         149      149           
=======================================
  Hits          148      148           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21239b1...7d795bf. Read the comment docs.

@hugovk hugovk mentioned this pull request Oct 20, 2018
Merged
4 tasks
@hugovk
Copy link
Contributor Author

hugovk commented Oct 31, 2018

Merge conflict resolved.

@misterdorm misterdorm added status: work in progress Twilio or the community is in the process of implementing difficulty: medium fix is medium in difficulty and removed status: code review request requesting a community code review or review from Twilio labels Oct 31, 2018
@hugovk
Copy link
Contributor Author

hugovk commented Aug 7, 2019

Hello, is there anything extra I can do for this PR? Thanks!

@hugovk
Copy link
Contributor Author

hugovk commented Sep 29, 2019

It's nearly time for the next Hacktoberfest! This PR has been approved, is anything else needed to merge it? Thanks!

@hugovk hugovk closed this Nov 16, 2019
@hugovk
Copy link
Contributor Author

hugovk commented Nov 16, 2019

Closing these year-old PRs. Let me know if you're still interested and I can re-open. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misterdorm misterdorm misterdorm approved these changes

Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: work in progress Twilio or the community is in the process of implementing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hugovk @misterdorm @thinkingserious