Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use Python's 'or', not '||' #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Use Python's 'or', not '||' #90

wants to merge 2 commits into from

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Oct 27, 2018

Fixes #89

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Python uses or, not ||

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 27, 2018
@hugovk hugovk mentioned this pull request Oct 27, 2018
Closed
@codecov
Copy link

codecov bot commented Oct 27, 2018 •
edited
Loading

Codecov Report

Merging #90 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #90   +/-   ##
=======================================
  Coverage   99.32%   99.32%           
=======================================
  Files           2        2           
  Lines         149      149           
=======================================
  Hits          148      148           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97cca34...f3613f5. Read the comment docs.

42B
42B reviewed Oct 27, 2018
View reviewed changes
42B
42B approved these changes Oct 27, 2018
View reviewed changes
Copy link

@42B 42B left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With your new commit, 9bcbc9a on #86 , it seems like this PR is now redundant and should be closed.

@42B 42B mentioned this pull request Oct 28, 2018
Merged
4 tasks
@misterdorm
Copy link

Closing in favor of #86.

@misterdorm misterdorm closed this Oct 31, 2018
@hugovk hugovk deleted the fix-or branch October 31, 2018 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@42B 42B 42B approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid syntax
4 participants
@hugovk @misterdorm @42B @thinkingserious