Codestin Search App

JJK801 · 2014-07-22T15:31:16Z

Hi,

When i try to update my dependencies using hhvm (hhvm /usr/local/bin/composer update), i get an error from your script:

sh: 1: /usr/bin/hhvm --php: not found

This is because the --php argument is escaped with the command, this PR fix it (maybe a better way, but i got no time to pend on it)

Thx

apfelbox · 2014-07-22T15:42:36Z

Shouldn't $self::getPhp() be self::getPhp()?

fabpot · 2014-07-22T15:42:59Z

oups, i'm gonna fix it :)

JJK801 · 2014-07-22T15:46:29Z

@apfelbox fixed, thanks :)

acoquoin · 2014-07-28T07:41:47Z

👍 It's a nice fix, i need it !

fabpot · 2014-07-28T09:38:15Z

The problem is that you might still need to escape the PHP path. That's a tricky issue as you cannot make a difference between what should be esacped and what should not.

I think the problem is more in PhpExecutableFinder where we can return some options like --php.

JJK801 · 2014-07-28T13:15:48Z

@fabpot my last commit will fix the problem once symfony/symfony#11497 merged

pyrech · 2014-07-28T13:21:23Z

typo here. Your $ key is too sensitive :)

xabbuh · 2014-07-28T13:35:01Z

should be $phpFinder = new PhpExecutableFinder();

It's not mandatory and not used in the coding style of the file (c.f getPhp function)

@xabbuh is right. We are using () everywhere... well except here apprentely ;)

DZunke · 2014-07-30T14:04:18Z

Thanks @JJK801 !

fabpot · 2014-08-05T13:14:43Z

If you get more than one argument, it won't work. So, this method should return an array instead (see my comment on the PR on symfony/symfony).

lsmith77 · 2014-09-11T05:59:46Z

any word when this will be merged and tagged? its preventing us from testing against HHVM with the CMF

fabpot · 2014-09-11T06:38:05Z

symfony/symfony#11497 should be merged first, but we are almost there.

stof · 2014-09-11T08:55:06Z

this should be guarded with a method_exists check to avoid fatal errors if an older version of Symfony is used (returning an empty array when the method does not eixsts)

Hi, When i try to update my dependencies using hhvm (hhvm /usr/local/bin/composer update), i get an error from your script: sh: 1: /usr/bin/hhvm --php: not found This is because the --php argument is escaped with the command, this PR fix it (maybe a better way, but i got no time to pend on it) Thx

Tobion · 2014-09-11T11:48:38Z

symfony uses single quotes

…ments (JJK801) This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #11497). Discussion ---------- Use separated function to resolve command and related arguments Hi, This PR split command and related arguments resolution into two distinct functions. It will help to solve the HHVM issue sensiolabs/SensioDistributionBundle#150 . Thanks, Jérémy | Q | A | ------------- | --- | Bug fix? | yes | New feature? | yes | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ Commits ------- ee75af0 Use separated function to resolve command and related arguments

FlorianKoerner · 2014-09-24T14:39:00Z

👍

fabpot · 2014-09-24T14:47:18Z

Thank you @JJK801.

This PR was squashed before being merged into the 3.0.x-dev branch (closes #150). Discussion ---------- Fix composer update via HHVM Hi, When i try to update my dependencies using hhvm (hhvm /usr/local/bin/composer update), i get an error from your script: sh: 1: /usr/bin/hhvm --php: not found This is because the --php argument is escaped with the command, this PR fix it (maybe a better way, but i got no time to pend on it) Thx Commits ------- b901596 Fix composer update via HHVM

JJK801 · 2014-09-24T14:55:21Z

@fabpot my pleasure

FlorianKoerner · 2014-09-24T15:25:20Z

Will it be fixed for 2.3.x too?

sroze · 2014-09-25T19:02:35Z

I'm still having the issue with hhvm /usr/local/bin/composer install because Composer is loading first its packaged version of Process component from its PHAR.
@JJK801 Did you experiment that issue ? And so, do you have any idea how to solve it ?

chasen · 2014-09-29T19:57:10Z

I have updated my composer json to use the dev-master build of the SensioDistributionBundle. My composer.lock confirms I am using the latest commit:

"name": "sensio/distribution-bundle",
    "version": "dev-master",
    "target-dir": "Sensio/Bundle/DistributionBundle",
     "source": {
         "type": "git",
        "url": "https://github.com/sensiolabs/SensioDistributionBundle.git",
        "reference": "e20461e4f8e1afd68f36cf90bdccc06f7aa6a6c2"

php -v
HipHop VM 3.3.0 (rel)
Compiler: tags/HHVM-3.3.0-0-g0a3cfb87b8a353fc7e1d15374f4adc413e37aba9
Repo schema: 9a391d9a03e15fccba1cde6d35c05b7cdd380238
Extension API: 20140829

composer version: 31eadc6920cd1866bc061fb0087798c37e2b7d14

running: composer update
results in:

sh: 1: /usr/bin/hhvm --php: not found
Script Sensio\Bundle\DistributionBundle\Composer\ScriptHandler::buildBootstrap handling the post-update-cmd event terminated with an exception

  [RuntimeException]
  An error occurred when generating the bootstrap file.

Am i missing something or did this PR not fix the issue?

sroze · 2014-09-29T20:21:25Z

@chasen I'm having the same issue, have a look on my previous comment. As workaround I'm using composer with --no-scripts argument and then clear cache by hand with hhvm.

FlorianKoerner · 2014-09-30T05:55:04Z

My Solution:

Replace all

"Sensio\\Bundle\\DistributionBundle\\Composer\\ScriptHandler::buildBootstrap"

with

"php vendor/sensio/distribution-bundle/Sensio/Bundle/DistributionBundle/Resources/bin/build_bootstrap.php"

in your composer.json

JJK801 · 2014-09-30T07:23:19Z

@sroze @chasen @FlorianKoerner Which version of SensioDistributionBundle are you using ? this PR is only merged for 3.0.6 tag for now

FlorianKoerner · 2014-09-30T07:26:40Z

Will it be fixed for 2.3.x too?

3.0.6 is incompatible with Symfony 2.3.x - so I can not use your solution.

chasen · 2014-09-30T07:28:04Z

@JJK801 I have tried it with 3.0.6 and with commit ID e20461e and neither worked.

sroze · 2014-09-30T07:54:49Z

@JJK801 Sure to have dev-master of SensioDistributionBundle as well as dev-master of Symfony but still not working because of this:

Composer is loading first its packaged version of Process component from its PHAR.

JJK801 · 2014-09-30T08:56:52Z

@sroze @FlorianKoerner @chasen as @sroze said, it seems to be a composer issue (pointing to symfony/process 2.5.4 but PR was tagged in 2.5.5), i'm gonna make a PR to fix it.

JJK801 · 2014-09-30T09:28:51Z

@sroze @chasen the composer PR composer/composer#3318 fix the problem.

@FlorianKoerner about the 2.3.x merge, i'm not maintainer of this projet, ask @fabpot about it or just update your symfony.

stof · 2014-09-30T10:22:37Z

see #168 for the Symfony 2.3 support

joshuataylor · 2014-10-01T06:18:03Z

Confirming that the composer self-update fixed this issue with the above changes, awesome thanks.

JJK801 · 2014-10-01T07:03:11Z

thanks for the feedback @joshuataylor

…tibility

estani · 2014-10-08T09:34:10Z

A workaround in case updating is not an option: composer/composer#3172

fabpot reviewed Jul 22, 2014
View reviewed changes

fabpot reviewed Jul 28, 2014
View reviewed changes

JJK801 mentioned this pull request Jul 28, 2014

Use separated function to resolve command and related arguments symfony/process#8

Closed

pyrech reviewed Jul 28, 2014
View reviewed changes

JJK801 mentioned this pull request Jul 28, 2014

Use separated function to resolve command and related arguments symfony/symfony#11497

Closed

xabbuh reviewed Jul 28, 2014
View reviewed changes

fabpot reviewed Aug 5, 2014
View reviewed changes

stof referenced this pull request in symfony/symfony Aug 18, 2014

[Process] fixed HHVM usage on the CLI

8fbea0f

pelepelin mentioned this pull request Sep 8, 2014

Composer is broken on hhvm composer/composer#3172

Closed

stof reviewed Sep 11, 2014
View reviewed changes

Jérémy JOURDIN added 6 commits September 11, 2014 11:25

Update ScriptHandler.php

b4ca876

Update ScriptHandler.php

7f3f379

Update ScriptHandler.php

f5cf5a3

Update ScriptHandler.php

9eb6b0e

Update ScriptHandler.php

fc95d26

JJK801 force-pushed the patch-1 branch from 0df76f5 to fc95d26 Compare September 11, 2014 09:25

Jérémy JOURDIN added 2 commits September 11, 2014 11:29

check id findArguments method exists

f522ab4

fix CS

9bda68f

Tobion reviewed Sep 11, 2014
View reviewed changes

Comment thread Composer/ScriptHandler.php Outdated

Copy link
Copy Markdown

Contributor

Tobion Sep 11, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

symfony uses single quotes

Fix CS

cf75946

fabpot closed this in 10b53fe Sep 24, 2014

JJK801 mentioned this pull request Sep 30, 2014

Update symfony/process to fix hhvm issues composer/composer#3318

Merged

lsmith77 added a commit to symfony-cmf/Testing that referenced this pull request Oct 3, 2014

apply fix from sensiolabs/SensioDistributionBundle#150 for hhvm compa…

883aba5

…tibility

lsmith77 mentioned this pull request Oct 3, 2014

apply hhvm fix symfony-cmf/Testing#73

Merged

lavoiesl mentioned this pull request Feb 19, 2015

Added support for HHVM in ScriptHandler Spea/SpBowerBundle#124

Merged

nbas11 mentioned this pull request Jul 28, 2015

Update version of sensio/distribution-bundle to 3.0 Sylius/Sylius#3088

Closed

Conversation

JJK801 commented Jul 22, 2014

Uh oh!

apfelbox commented Jul 22, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JJK801 commented Jul 22, 2014

Uh oh!

acoquoin commented Jul 28, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JJK801 commented Jul 28, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DZunke commented Jul 30, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lsmith77 commented Sep 11, 2014

Uh oh!

fabpot commented Sep 11, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FlorianKoerner commented Sep 24, 2014

Uh oh!

fabpot commented Sep 24, 2014

Uh oh!

JJK801 commented Sep 24, 2014

Uh oh!

FlorianKoerner commented Sep 24, 2014

Uh oh!

sroze commented Sep 25, 2014

Uh oh!

chasen commented Sep 29, 2014

Uh oh!

sroze commented Sep 29, 2014

Uh oh!

FlorianKoerner commented Sep 30, 2014

Uh oh!

JJK801 commented Sep 30, 2014

Uh oh!

FlorianKoerner commented Sep 30, 2014

Uh oh!

chasen commented Sep 30, 2014

Uh oh!

sroze commented Sep 30, 2014

Uh oh!

JJK801 commented Sep 30, 2014

Uh oh!

JJK801 commented Sep 30, 2014

Uh oh!

stof commented Sep 30, 2014

Uh oh!

joshuataylor commented Oct 1, 2014

Uh oh!

JJK801 commented Oct 1, 2014

Uh oh!

estani commented Oct 8, 2014

Uh oh!

Reviewers