Add HTML support (with options!)#41
Open
Kocal wants to merge 1 commit into
Open
Conversation
Kocal
commented
May 20, 2026
| /.php-cs-fixer.cache | ||
| /composer.lock | ||
| /phpunit.xml | ||
| /tests/Fixtures/config/ |
Author
There was a problem hiding this comment.
(config/reference.php file was being generated with latest Symfony deps)
Kocal
commented
May 20, 2026
Comment on lines
+8
to
+10
| ## 1.2.0 | ||
|
|
||
| - Add Symfony 8 support |
Author
There was a problem hiding this comment.
This one was missing from the previous release
Kocal
added a commit
to bakslashHQ/baksla.sh
that referenced
this pull request
May 20, 2026
…improvements Related to our LinkedIn post preview issue... The `og:image` can't be displayed because of missing `<head>` tags. Opened sensiolabs/minify-bundle#41.
Kocal
added a commit
to bakslashHQ/baksla.sh
that referenced
this pull request
May 20, 2026
…improvements Related to our LinkedIn post preview issue... The `og:image` can't be displayed because of missing `<head>` tags. Opened sensiolabs/minify-bundle#41.
mtarld
pushed a commit
to bakslashHQ/baksla.sh
that referenced
this pull request
May 21, 2026
…improvements (#149) Related to our LinkedIn post preview issue... The `og:image` can't be displayed because of missing `<head>` tags. Opened sensiolabs/minify-bundle#41.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use this bundle on baksla.sh to programmatically minify HTML files (SSG), but today we ran into an issue where the site preview on LinkedIn wasn't working: our
og:imagetag was being ignored.It turns out that LinkedIn's parser (https://www.linkedin.com/post-inspector/) doesn't work correctly when the
<head>and</head>tags are missing... 😫This PR adds support for HTML and options (just one option for now, KISS), but only in the low-level
MinifyInterface::minify()method.I deliberately did not touch the bundle (i.e., adding configuration to
SensiolabsMinifyBundleand modifying theMinifierCompiler, etc..), because I don't think it makes sense with the AssetMapper's integration (JS/CSS only).