Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use micromamba/v2 as default build template for conda packages#1024

Merged
pditommaso merged 5 commits into
masterfrom
default-micromamba-v2-template
Jun 14, 2026
Merged

Use micromamba/v2 as default build template for conda packages#1024
pditommaso merged 5 commits into
masterfrom
default-micromamba-v2-template

Conversation

@pditommaso

@pditommaso pditommaso commented Apr 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Switch the default build template for CONDA packages from conda/micromamba:v1 to conda/micromamba:v2
  • BuildTemplate.defaultTemplate() now returns CONDA_MICROMAMBA_V2 for CONDA package type
  • ContainerHelper.containerFileFromRequest() routes to v2 by default, v1 only when explicitly requested
  • Existing v1 tests updated to explicitly specify CONDA_MICROMAMBA_V1 template

Test plan

  • Existing unit tests pass (ContainerHelperTest, CondaHelperTest)
  • Verify conda builds on staging use v2 template by default
  • Verify explicit conda/micromamba:v1 template still works

🤖 Generated with Claude Code

@pditommaso pditommaso mentioned this pull request Apr 15, 2026
Merged
3 tasks
pditommaso and others added 3 commits June 4, 2026 22:31
@pditommaso
Merge branch 'master' into default-micromamba-v2-template
4a510ad
@pditommaso
Merge branch 'master' into default-micromamba-v2-template
eeecf09
@pditommaso @claude
test: cover default conda template routing to micromamba v2
745e323 
Add a ContainerHelperTest case asserting that a CONDA request with no
explicit buildTemplate generates the micromamba v2 container file. This
exercises the null -> v2 routing in containerFileFromRequest, the core
behavior change of this PR, which no existing test covered.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
@pditommaso

pditommaso commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator Author

Review summary — merging ✅

What this changes: switches the default build template for CONDA packages from conda/micromamba:v1 to conda/micromamba:v2.

  • ContainerHelper.containerFileFromRequest() routing inverted: no template (or explicit v2) → containerFileV2(); explicit v1 → legacy containerFile().
  • BuildTemplate.defaultTemplate() now returns CONDA_MICROMAMBA_V2 for CONDA (was null) — this also repairs a latent mismatch where default conda builds generated v1 content but persisted/displayed the template as (default).
  • Existing v1 tests pinned to CONDA_MICROMAMBA_V1; BuildTemplateTest expectation updated.
  • Added test should create conda docker file with packages using micromamba v2 by default, covering the previously-untested null → v2 routing (the core behavior change).

Verification: Wave CI green — Build Wave (21) ✓, submit-gradle ✓. ContainerHelperTest passes locally (107 tests, 0 failures).

Operational note: generated container files change for all default conda builds → new container IDs → cache invalidation and rebuilds on rollout. v2 images differ materially (e.g. ubuntu:24.04 prod stage, procps-ng, CUDA-override logic). Worth monitoring build load after deploy.

Merged via admin override (branch protection required an approving review; PR is author-owned).

@pditommaso pditommaso merged commit 584dd70 into master Jun 14, 2026
3 checks passed
@pditommaso pditommaso deleted the default-micromamba-v2-template branch June 14, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@pditommaso