Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix creds validation endpoint#740

Merged
pditommaso merged 2 commits into
masterfrom
fix-creds-validation
Nov 14, 2024
Merged

Fix creds validation endpoint#740
pditommaso merged 2 commits into
masterfrom
fix-creds-validation

Conversation

@pditommaso

Copy link
Copy Markdown
Collaborator

This PR reverts the use of @Body annotation in the /validate-creds endpoint because it represents a braking change

Boolean validateCreds(@Valid ValidateRegistryCredsRequest request){

when using @Body the post payload should be provided as

{"userName":"value","password":"value","registry":"value"} 

Instead without @Body the payload should be

{"request": {"userName":"value","password":"value","registry":"value"} }

Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
@pditommaso pditommaso merged commit 8c0f3a4 into master Nov 14, 2024
@pditommaso pditommaso deleted the fix-creds-validation branch November 14, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant