feat(types): handle Numbers passed as Objects#10492
Merged
sushantdhiman merged 1 commit intosequelize:masterfrom Mar 2, 2019
Merged
feat(types): handle Numbers passed as Objects#10492sushantdhiman merged 1 commit intosequelize:masterfrom
sushantdhiman merged 1 commit intosequelize:masterfrom
Conversation
This adds support for Number types that aren't represented as actual Javascript Number instances. For example, BigInt (new in Node 10), Decimal.js, etc. Fixes sequelize#10491
gabegorelick
commented
Mar 2, 2019
| "@types/bluebird": "^3.5.26", | ||
| "@types/node": "^10.12.27", | ||
| "@types/validator": "^10.9.0", | ||
| "big-integer": "^1.6.42", |
Contributor
Author
There was a problem hiding this comment.
Shim for BigInt, which is new in Node 10. See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt.
Codecov Report
@@ Coverage Diff @@
## master #10492 +/- ##
==========================================
+ Coverage 93.01% 96.15% +3.14%
==========================================
Files 91 92 +1
Lines 9261 9501 +240
==========================================
+ Hits 8614 9136 +522
+ Misses 647 365 -282
Continue to review full report at Codecov.
|
sushantdhiman
approved these changes
Mar 2, 2019
gabegorelick
added a commit
to gabegorelick/sequelize
that referenced
this pull request
Mar 2, 2019
This adds support for Number types that aren't represented as actual Javascript Number instances. For example, BigInt (new in Node 10), Decimal.js, etc. Backports sequelize#10492 to v4
5 tasks
gabegorelick
added a commit
to gabegorelick/sequelize
that referenced
this pull request
Mar 28, 2019
This regressed in sequelize#10492 Fixes sequelize#10600
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for Number types that aren't represented as actual Javascript Number instances. For example, BigInt (new in Node 10), Decimal.js, etc. Anything with a
.toStringshould work.Fixes #10491
Pull Request check-list
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
Fixes #10491