Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make absolute ratelimits a runtime config instead of feature #2246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 28, 2022
Merged

Make absolute ratelimits a runtime config instead of feature #2246

merged 4 commits into from
Oct 28, 2022

Conversation

kangalio
Copy link
Collaborator

@kangalio kangalio commented Oct 25, 2022 •
edited
Loading

Screenshot_20221026_011244

One feature down

@github-actions github-actions bot added the http Related to the `http` module. label Oct 25, 2022
@arqunis arqunis added enhancement An improvement to Serenity. breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users labels Oct 27, 2022
arqunis
arqunis requested changes Oct 27, 2022
View reviewed changes
Copy link
Member

@arqunis arqunis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a premature approval (not that the changes are bad). Could you also remove the absolute_ratelimits feature, or add a warning to build.rs that it's deprecated and you must now configure Http at runtime?

@kangalio
Copy link
Collaborator Author

Done
Screenshot_20221027_184355

@kangalio
Copy link
Collaborator Author

Good catch, by the way, thanks :)

@kangalio
Use "full" feature alias instead of --all-features
222e4a5 
Because --all-features also enables absolute_ratelimits, which triggers a compile_error
@github-actions github-actions bot added the ci Related to the continuous integration. label Oct 27, 2022
@kangalio
Copy link
Collaborator Author

The CI failure is unrelated to this PR. It happens on upstream next too and is due to a bad interaction of #2254 and #2256

@arqunis arqunis merged commit fd2ff26 into serenity-rs:next Oct 28, 2022
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Nov 7, 2022
@kangalio @mkrasnitski
Make absolute ratelimits a runtime config instead of a feature (seren…
8fc3644 
…ity-rs#2246)
arqunis pushed a commit that referenced this pull request Nov 13, 2022
@kangalio @arqunis
Make absolute ratelimits a runtime config instead of a feature (#2246)
ac8bf75
@kangalio kangalio mentioned this pull request Feb 5, 2023
Closed
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Feb 28, 2023
@kangalio @mkrasnitski
Make absolute ratelimits a runtime config instead of a feature (seren…
889d7cf 
…ity-rs#2246)
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request May 18, 2023
@kangalio @mkrasnitski
Make absolute ratelimits a runtime config instead of a feature (seren…
1f7ac03 
…ity-rs#2246)
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request May 30, 2023
@kangalio @mkrasnitski
Make absolute ratelimits a runtime config instead of a feature (seren…
3410ab7 
…ity-rs#2246)
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Sep 21, 2023
@kangalio @mkrasnitski
Make absolute ratelimits a runtime config instead of a feature (seren…
02df422 
…ity-rs#2246)
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 17, 2023
@kangalio @mkrasnitski
Make absolute ratelimits a runtime config instead of a feature (seren…
e5f1946 
…ity-rs#2246)
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 24, 2023
@kangalio @mkrasnitski
Make absolute ratelimits a runtime config instead of a feature (seren…
b2fd7d6 
…ity-rs#2246)
arqunis pushed a commit to arqunis/serenity that referenced this pull request Oct 24, 2023
@kangalio @arqunis
Make absolute ratelimits a runtime config instead of a feature (seren…
b466440 
…ity-rs#2246)
arqunis pushed a commit to arqunis/serenity that referenced this pull request Oct 24, 2023
@kangalio @arqunis
Make absolute ratelimits a runtime config instead of a feature (seren…
8237ae7 
…ity-rs#2246)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arqunis arqunis arqunis approved these changes

Assignees
No one assigned
Labels
breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users ci Related to the continuous integration. enhancement An improvement to Serenity. http Related to the `http` module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kangalio @arqunis