This repository was archived by the owner on Dec 9, 2024. It is now read-only.
Fixed alarm annotations of trigger can not be saved #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #168 +/- ##
==========================================
+ Coverage 84.8% 85.04% +0.24%
==========================================
Files 47 47
Lines 1829 1826 -3
Branches 378 378
==========================================
+ Hits 1551 1553 +2
+ Misses 278 273 -5
Continue to review full report at Codecov.
|
|
@jthomas Could you have a look at this? |
|
@style95 Let me have a look at this tomorrow. |
|
@jthomas Thank you so much. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#167
If the feed exists, I changed it to match the
ow.trigger.create()'s parameter format. I have also added tests for this