Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Ability to split reconciler duties #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nebhale merged 19 commits into from
Jul 23, 2020
Merged

Ability to split reconciler duties #74

nebhale merged 19 commits into from
Jul 23, 2020

Conversation

@arthurdm
Copy link
Member

@arthurdm arthurdm commented Jul 13, 2020

Fixes #63

Adding a section that splits reconciler duties.

arthurdm added 2 commits July 13, 2020 11:25
@arthurdm
Ability to split reonciler duties
4f43c8f 
Signed-off-by: Arthur De Magalhaes <[email protected]>
@arthurdm
Fixing typo
289065f 
Signed-off-by: Arthur De Magalhaes <[email protected]>
@arthurdm arthurdm requested review from nebhale and scothis and removed request for nebhale July 13, 2020 15:29
@arthurdm
Copy link
Member Author

arthurdm commented Jul 13, 2020

hey @nebhale - when we reach agreement on this PR, could you please help with the CRD code generation update for the new flag?

@arthurdm arthurdm requested a review from nebhale July 13, 2020 15:36
scothis
scothis reviewed Jul 13, 2020
View reviewed changes
Copy link
Member

@scothis scothis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple significant lifecycle issues with this as written. Comments inline. Given the impact of these issues, I'm not sure this belongs in core and may be better as a spec extension.

It would be good to also update the exemplar CRD schema since this is changing the shape of the resource.

arthurdm added 2 commits July 17, 2020 16:16
@arthurdm
Simplifying duty split
c9dd1cf 
Signed-off-by: Arthur De Magalhaes <[email protected]>
@arthurdm
Updating example
78d14d6 
Signed-off-by: Arthur De Magalhaes <[email protected]>
@arthurdm
Copy link
Member Author

arthurdm commented Jul 17, 2020

@scothis / @nebhale - I have now simplified the PR text and switched to using Enums. I tried to make it clear that processing of ServiceBinding is shared, as 2 elements are processed by each framework.

Avni-Sharma
Avni-Sharma reviewed Jul 19, 2020
View reviewed changes
arthurdm added 5 commits July 20, 2020 14:52
@arthurdm
Using an internal resource
2651113 
Signed-off-by: Arthur De Magalhaes <[email protected]>
@arthurdm
Fixing typo
f75cc5a 
Signed-off-by: Arthur De Magalhaes <[email protected]>
@arthurdm
Typo
d7bee58 
Signed-off-by: Arthur De Magalhaes <[email protected]>
@arthurdm
Add sentence about synch
e520ddb 
Signed-off-by: Arthur De Magalhaes <[email protected]>
@arthurdm
Typo
709c3bd 
Signed-off-by: Arthur De Magalhaes <[email protected]>
@arthurdm
Copy link
Member Author

arthurdm commented Jul 20, 2020

latest commits push this work into an extension, as we define a new annotation and CRD (internal) for the reconciler separation.

scothis
scothis reviewed Jul 20, 2020
View reviewed changes
Copy link
Member

@scothis scothis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the direction here

arthurdm and others added 5 commits July 20, 2020 16:26
@arthurdm
Clarify projection responsibility
286e863 
Signed-off-by: Arthur De Magalhaes <[email protected]>
@arthurdm @scothis
Update README.md
f608b83 
Co-authored-by: Scott Andrews <[email protected]>
@arthurdm @scothis
Update README.md
6d444f9 
Co-authored-by: Scott Andrews <[email protected]>
@arthurdm
Updating annotation name
46b362c 
Signed-off-by: Arthur De Magalhaes <[email protected]>
@arthurdm
Reverting to optional secret
564c98c 
Signed-off-by: Arthur De Magalhaes <[email protected]>
scothis
scothis reviewed Jul 21, 2020
View reviewed changes
arthurdm and others added 2 commits July 21, 2020 10:10
@arthurdm @scothis
Update README.md
6d4a9a4 
Co-authored-by: Scott Andrews <[email protected]>
@arthurdm
Updating status subtitle
3e76639 
Signed-off-by: Arthur De Magalhaes <[email protected]>
scothis
scothis reviewed Jul 22, 2020
View reviewed changes
Copy link
Member

@scothis scothis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more small suggestions after which I think we're good to go

arthurdm and others added 2 commits July 22, 2020 21:07
@arthurdm
Keep reconcilation simple
dc71d11 
Signed-off-by: Arthur De Magalhaes <[email protected]>
@arthurdm @scothis
Update README.md
3666ee9 
Co-authored-by: Scott Andrews <[email protected]>
@arthurdm @scothis
Update README.md
b78f549 
Co-authored-by: Scott Andrews <[email protected]>
@arthurdm
Copy link
Member Author

arthurdm commented Jul 23, 2020

thanks for the helpful reviews / commits @scothis! I believe all of the comments were addressed.

@nebhale nebhale requested a review from Avni-Sharma July 23, 2020 18:40
@nebhale nebhale merged commit c6c1f25 into master Jul 23, 2020
@sbose78
Copy link
Contributor

sbose78 commented Oct 7, 2020

Hi, greetings folks.

Apart from runtime component operator, is any other operator planning to write a reconciler ( or thinking of a similar usecase ) for ServiceBindingProjection at the moment ?

@scothis
Copy link
Member

scothis commented Oct 7, 2020

Part of the intent behind custom projection is that we don't need to know. Anybody can hook in at any point in the future without our knowledge.

@nebhale nebhale deleted the reconcileDuties branch October 28, 2021 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nebhale nebhale nebhale approved these changes

@scothis scothis scothis approved these changes

@Avni-Sharma Avni-Sharma Awaiting requested review from Avni-Sharma

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

How to control reconcile duties

6 participants

@arthurdm @sbose78 @scothis @nebhale @Avni-Sharma