Expose is_servo_internal for gc outside about scope#45032
Open
janeoa wants to merge 4 commits into
Open
Conversation
Signed-off-by: Jane <[email protected]>
Contributor
|
Does this enable other features if we are privileged? |
Contributor
Yes, all the methods of the ServoInternals interface. |
Contributor
|
@janeoa I think then the pref should be called something like: "expose_servointernals_globally" |
Signed-off-by: Jane <[email protected]>
8e31579 to
c86fb82
Compare
Signed-off-by: Jane <[email protected]>
Narfinger
suggested changes
May 21, 2026
Contributor
|
Just small nits, otherwise looks good to me! |
Co-authored-by: Narfinger <[email protected]> Signed-off-by: Asset Malik <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More context in the #44878. But generally. I wanted to be able to run
In the
blink-perf-test'srunner.jsso that it does not use the strange fallback method.So now, this PR introduces
--pref dom_servo_gc_enabled=trueThat makes
is_servo_internalin thecomponents/script/dom/servointernals.rsto returntrue, so that thenavigator.servo.garbageCollectAllContexts()could be called outside theabout:memoryurl.Testing: To test, I've locally put a
print!in thefn GarbageCollectAllContexts(&self)that is in thecomponents/script/dom/servointernals.rsand run the servo with and without the--pref dom_servo_gc_enabled=true. As expected, theprint!worked only when the correct--prefis present.Fixes: #44878