devtools: Fix inspector not loading when navigating on the same page#45056
Open
eerii wants to merge 1 commit into
Open
devtools: Fix inspector not loading when navigating on the same page#45056eerii wants to merge 1 commit into
eerii wants to merge 1 commit into
Conversation
Previously, navigating on a website with the DevTools inspector open would make it end up blank, something that could only be fixed by disconnecting the DevTools client and connecting again. Signed-off-by: eri <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, navigating on a website with the DevTools inspector open would make it not show the new HTML tree and not properly update. It could only be fixed by disconnecting the DevTools client and connecting again.
Now navigation correctly updates the inspector, both for the same page and external navigation. We now get the
BrowsingContextActorthrough theWatcherActor, which remains the same across navigations (unlikeBrowsingContextActor). As a result, many actors were changed to have a reference to the watcher instead.This is also a first step in cleaning the actor dependencies and avoid registration issues.
Know issues (better addressed in followups):
ActorRegistryalready mutably borrowed #45055Testing: ./mach test-devtools
Fixes: #41848
Fixes: #42603
Part of: #39862
Part of: #45055