Respond to changes in animation-delay#371
Open
yezhizhen wants to merge 1 commit into
Open
Conversation
animation-delayanimation-delay
Member
|
@yezhizhen Do you mind writing a bit more about what this change does in the PR description? I think it is useful for people reading the repository history. |
Member
Author
|
I made a mistake. This only works for static ones. We cannot use the new The new passing WPT are all static ones. |
Signed-off-by: Euclid Ye <[email protected]>
Member
Author
|
Fixed. Now it works correctly on running ones. Still recommend "Hide Whitespace diff" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update_from_otherunconditionally restored the oldstarted_at, ignoring the new delay.To fix this, computed the correct
started_atwith the new delay.We also compute the fresh new state based on it.
Servo companion: servo/servo#45013