Fixes for bb8 #321
Merged
Fixes for bb8 #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can't put a Handshake in a lazy_static if it needs any runtime-derived configuration. I think it may make more sense for bb8 to define a |
|
If it needs runtime configuration other than environment variables or similar, sure. Do you know of examples of usage that I can look at? |
|
I don't know of any public examples offhand, but it's relatively common for an application to read a config file and initialize things based off of that at startup, including its connection pool. |
|
Alright lets just drop those csets then. |
|
Poke? |
|
ty! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To write bb8 (https://github.com/khuey/bb8) I made a few modifications to tokio_postgres. These do change the exposed interface.
Handshakeno longer consumes itself. This wasn't necessary and allows a singleHandshaketo be shared among multiple connections.is_desynchronizedis added, mirroring the one in syncpostgres.TlsModeenum now holds references, like its equivalent in syncpostgres. This requires bounding a couple futures to the lifetime of theTlsMode. I expect this to be the most controversial part. Since you can still shove yourHandshakein alazy_static!to get the static lifetime if you really need it I don't think this is a huge issue.