Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC: add compatibility for sphinxcontrib-bibtex>=2 #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 19, 2021
Merged

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Jan 18, 2021

the test in #168 are failing as sphinxcontrib-bibtex introduced a breaing change with version 2.0.0 as you have to add another config setting.

This fixes thie issue.

@mgeier
Copy link
Member

mgeier commented Jan 18, 2021

I think now the references.bib argument can be removed from references.rst:

.. bibliography:: references.bib
    :style: alpha
    :all:

Also, I think :all: isn't necessary anymore, right?

I'm not sure though, because I cannot check it locally because I'm getting some errors (which may be related to my broken installation).

@hagenw
Copy link
Member Author

hagenw commented Jan 19, 2021

Thanks, references.bib is indeed no longer needed. :all: includes all references, also not cited once. I removed that option as well.
I was able to execute the code locally and found also one wrong citation to Ahrens2012 that was not using the bibtex plugin, and corrected that as well.

Copy link
Member

@mgeier mgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fs446 fs446 merged commit 21bd666 into master Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants