Clip soundfield into float64 range for plotting #57
Conversation
|
I'm also in favor of including a fix for this. |
|
I wouldn't restrict the The fix suggested by @trettberg seems less intrusive, but what about limiting the fix to the affected versions (since it looks like it'll be fixed in 2.2.0)? import matplotlib
if matplotlib.__version__.startswith('2.1'):
p = np.clip(p, -1e15, 1e15) |
sfs/plot.py
Outdated
| @@ -284,6 +285,9 @@ def soundfield(p, grid, xnorm=None, cmap='coolwarm_clip', vmin=-2.0, vmax=2.0, | |||
| if ax is None: | |||
| ax = plt.gca() | |||
|
|
|||
| if matplotlib_version.startswith('2.1.'): | |||
| p = np.clip(p, -1e15, 1e15) # clip to float64 range | |||
There was a problem hiding this comment.
Maybe we add a link to the matplotlib bug (matplotlib/matplotlib#10567) on the line before to highlight why we are doing this?
There was a problem hiding this comment.
Otherwise this implementation is fine with me.
closes #50
(This may become obsolete in matplotlib 2.2 or not.
Since it's easy enough, I propose to fix it now anyway.)