Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Bug] Fix accidental logger override caused by internVL. #6282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025

Conversation

lifuhuang
Copy link
Collaborator

Motivation

I noticed that sglang stopped logging info level logs whenever I use multimodal models. E.g. there is no "the server is fired up and ready to roll" when I load any multimodal model:
image

I debugged a little bit and found out it's introduced in #5350: sglang loads all processors when loading multimodal model, and internvl introduced numpy.distutils which has a known bug (see: numpy/numpy#24213).
image
image

Upon further reading, I found out the introduction of this package might have been a bug itself, as the only location where cpu is used is actually expecting decord.cpu instead of numpy.distutils.cpuinfo.cpu, so I removed the line and the logging is working again:
image

Modifications

Checklist

@zhyncs zhyncs merged commit 3e350a9 into sgl-project:main May 14, 2025
4 of 31 checks passed
@lifuhuang lifuhuang deleted the lifuh/log branch May 14, 2025 06:37
lifuhuang added a commit to lifuhuang/sglang that referenced this pull request May 17, 2025
woodx9 pushed a commit to woodx9/sglang that referenced this pull request May 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants