fix(dialog): add closeLabel prop for i18n support in DialogContent and DialogFooter (base-mira)#10599
Open
NianJiuZst wants to merge 1 commit into
Open
fix(dialog): add closeLabel prop for i18n support in DialogContent and DialogFooter (base-mira)#10599NianJiuZst wants to merge 1 commit into
NianJiuZst wants to merge 1 commit into
Conversation
…d DialogFooter
Add optional closeLabel prop (default: 'Close') to both DialogContent
and DialogFooter in the base-mira style. This allows localized
applications to pass a translated string (e.g. closeLabel={t('dialog.close')})
without forking the registry file.
Fixes the hardcoded English 'Close' strings that leaked into:
- DialogContent: sr-only span for screen-reader accessibility
- DialogFooter: visible outline-button close control
Backwards compatible — existing consumers get the same 'Close' default.
Contributor
|
@NianJiuZst is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Can you sign the commits please? See https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an optional
closeLabelprop (default: Close) toDialogContentandDialogFooterin the base-mira registry style. This enables localized applications to pass a translated string without forking the registry file.Problem
<span className="sr-only">Close</span>breaks screen-reader i18nFix
Both DialogContent and DialogFooter now accept an optional
closeLabelprop:Default is "Close" for backwards compatibility.
Files changed
apps/v4/styles/base-mira/ui/dialog.tsx
Related