Address structured buffer GetDimensions issues for WGSL, GLSL and SPIRV
#7010
+125
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetDimensions issues for WGSL, GLSL and SPIRV
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few issues for structured buffer
GetDimensions:IRSizeAndAlignmentDecorationbut this decoration is not always created. This causes the compiler to crash when targetting WGSL and silently giving incorrect stride results when targetting GLSL.This PR fixes these by always creating a
IRSizeAndAlignmentDecorationfor structured buffers and properly accessing the size and alignment decoration when targetting SPIRV.Fixes #6842.