cuda: Add more formats for texture read/write #7012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11b2304 to
6da273d
Compare
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
mkeshavaNV
added a commit
to mkeshavaNV/slang
that referenced
this pull request
May 8, 2025
Format code for PR shader-slang#7012
9f3a413 to
cec4975
Compare
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
Format code for PR shader-slang#7012
skallweitNV
previously approved these changes
May 8, 2025
| @@ -14,6 +14,10 @@ RWTexture1D<float> rwt1D; | |||
| RWTexture2D<float> rwt2D; | |||
| //TEST_INPUT: RWTexture3D(format=R32Float, size=4, content = one, mipMaps = 1):name rwt3D | |||
| RWTexture3D<float> rwt3D; | |||
| //TEST_INPUT: RWTexture2D(format=RG32Float, size=4, content = one, mipMaps = 1):name rwt2D_float2 | |||
| RWTexture2D<float2> rwt2D_float2; | |||
There was a problem hiding this comment.
you could add float2/float4 versions for 1D and 3D as well to improve coverage even further
There was a problem hiding this comment.
@skallweitNV - good suggestion. Added.
expipiplus1
requested changes
May 8, 2025
0922312 to
855ad87
Compare
csyonghe
reviewed
May 8, 2025
prelude/slang-cuda-prelude.h
Outdated
| SLANG_FORCE_INLINE SLANG_CUDA_CALL float2 tex2Dfetch_int(CUtexObject texObj, int x, int y) | ||
| { | ||
| float result_x, result_y; | ||
| float dummy; |
There was a problem hiding this comment.
Coding style: we should avoid using offensive terms like dummy here. Consider “placeholder”, “stub”, etc.
csyonghe
reviewed
May 8, 2025
| } | ||
| } | ||
|
|
||
| // CHECK:0 |
There was a problem hiding this comment.
Generally avoid results that are 0, because various failures can also result a value being 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Fixes #7002 and #7025. Details are as shown below
#7025
#7002
2. Extend subscript operator support to include vectors.