Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bitcast require the input has same width with result type #7018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 7, 2025

Conversation

kaizhangNV
Copy link
Contributor

Fix the issue in lowering bitcast that it requires input has the same width with result type.

Close #7017.

@kaizhangNV kaizhangNV requested a review from a team as a code owner May 6, 2025 20:05
@kaizhangNV kaizhangNV added the pr: non-breaking PRs without breaking changes label May 6, 2025
@jkwak-work
Copy link
Collaborator

jkwak-work commented May 6, 2025

It looks like CI tests are failing.
I vaguely remember something like this last year.
We required the size to be same but it caused a problem so we relaxed it
I am not sure if it was the same thing as this one.

@kaizhangNV
Copy link
Contributor Author

kaizhangNV commented May 6, 2025

I see, this is a problem that we either solve at spirv emit stage, or at IR stage.
Really depends how we define the rule of this IR.

@kaizhangNV
Copy link
Contributor Author

The error seems like we don't support int cast from pointer to integer, so I should rule that out from the integer cast.

csyonghe
csyonghe previously approved these changes May 7, 2025
@kaizhangNV kaizhangNV merged commit ccdb2e3 into shader-slang:master May 7, 2025
16 checks passed
@kaizhangNV kaizhangNV deleted the fix_bitcast branch May 7, 2025 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bitcast lowering issue: input has different width from result type
3 participants