Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

stevenengler
Copy link
Contributor

@stevenengler stevenengler commented May 7, 2021

The unsafe_op_in_unsafe_fn Rust lint has been stabilized and I think we should use it. The lint is currently off by default, but they plan to make it a warning and possibly an error in the future.

Edit: Blocked on #1330.

@stevenengler stevenengler added Type: Maintenance Refactoring, cleanup, documenation, or process improvements Component: Main Composing the core Shadow executable labels May 7, 2021
@stevenengler stevenengler self-assigned this May 7, 2021
@stevenengler stevenengler requested a review from sporksmith May 7, 2021 18:50
@stevenengler
Copy link
Contributor Author

stevenengler commented May 7, 2021

Oops, forgot that we're using an older nightly version for the coverage. I'll see if we can update that.

Copy link
Contributor

@sporksmith sporksmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Yeah it always bothered me that it wouldn't even let you use unsafe blocks in an unsafe function (or at least it would warn?), much less require it.

LGTM pending getting coverage working again

@stevenengler stevenengler enabled auto-merge May 13, 2021 21:55
@stevenengler stevenengler merged commit 0d13939 into shadow:dev May 13, 2021
@stevenengler stevenengler deleted the unsafe-fn branch May 13, 2021 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Main Composing the core Shadow executable Type: Maintenance Refactoring, cleanup, documenation, or process improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants