lib/get_pid.c: pid_t is a signed integer#1264
Merged
Merged
Conversation
Closed
|
One should ideally do just one change in the commit. 2 commits would be much better. Otherwise LGTM |
Collaborator
Author
Hmmm, yeah, I can split it in two. |
Acked-by: Lukas Slebodnik <[email protected]> Signed-off-by: Alejandro Colomar <[email protected]>
Print it with "%d". Acked-by: Lukas Slebodnik <[email protected]> Signed-off-by: Alejandro Colomar <[email protected]>
Collaborator
Author
|
@lslebodn I have taken your comment as an Acked-by. And have split the PR into two commits. Thanks! |
hallyn
approved these changes
Jun 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Print it with "%d". Also, we need to adapt the size of the allocation. To avoid making mistakes, just make it
PATH_MAX, and let the compiler optimize that if it's smart enough.This is a cherry-pick from
I cherry-picked it, because I want to have it in soon, because of #1222 (comment). I'm blocking a PR from @sthibaul due to this, and I'd like to solve that.
Revisions:
v2