lib/subordinateio.c: list_owner_ranges(): Fix duplicate range when username matches ID#1345
Merged
Merged
Conversation
…ername matches ID Fixes: 3ec32f9 (2022-07-20; "subordinateio: also compare the owner ID") Closes: <shadow-maint#1339> Link: <cri-o/cri-o#9416> Reported-by: Anatolii Bazko <[email protected]> Signed-off-by: Alejandro Colomar <[email protected]>
Collaborator
|
This approach makes the code more reliable, but before approving I'd like to understand the scenario that led to this point. |
Collaborator
Author
Agree; I prefer knowing exactly how it happened. |
|
Hello. |
ikerexxe
approved these changes
Aug 28, 2025
Collaborator
ikerexxe
left a comment
There was a problem hiding this comment.
LGTM! No other objections from my side. @alejandro-colomar if you are also fine feel free to merge this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: 3ec32f9 (2022-07-20; "subordinateio: also compare the owner ID")
Closes: #1339
Link: cri-o/cri-o#9416
Reported-by: @tolusha