Update po and potfiles#1399
Merged
Merged
Conversation
Collaborator
Collaborator
|
Cc: @zeha |
ikerexxe
approved these changes
Dec 5, 2025
Collaborator
ikerexxe
left a comment
There was a problem hiding this comment.
LGTM. Remember to update the ticket before merging
Member
Author
|
On Fri, Dec 05, 2025 at 05:12:10AM -0800, Iker Pedrosa wrote:
@ikerexxe approved this pull request.
LGTM. Remember to update the ticket before merging
sorry, what do you mean by that? Do you mean closing the issue, or
something else?
|
Collaborator
Member
Author
|
On Fri, Dec 05, 2025 at 05:16:01AM -0800, Iker Pedrosa wrote:
ikerexxe left a comment (shadow-maint/shadow#1399)
> sorry, what do you mean by that? Do you mean closing the issue, or something else?
You linked an incorrect ticket. Alejandro mentions the good one several messages above:
> The Closes tag has a typo. It's #1359, not #1395.
Wow!
Thanks Iker and Alex!
|
I just did a 'make dist', then committed the updates to the po and shadow.pot files. Closes shadow-maint#1359 Signed-off-by: Serge Hallyn <[email protected]> CC: Chris Hofstaedtler <[email protected]>
c96ff91 to
402d4fa
Compare
alejandro-colomar
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just did a 'make dist', then committed the updates to the po and shadow.pot files.
Closes #1395