add tests for BaseGeometry._repr_svg_ #1311
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sgillies I prepared this PR so we can get some tests in before changing the SVG functionality. |
Pull Request Test Coverage Report for Build 1813929098
💛 - Coveralls |
sgillies
reviewed
Feb 11, 2022
| import xml.etree.ElementTree as ET | ||
|
|
||
| from . import unittest | ||
| from shapely.geometry import Point, MultiPoint, LineString, MultiLineString,\ |
There was a problem hiding this comment.
Nit: black would eliminate the forward slash and turn these into a list.
sgillies
reviewed
Feb 11, 2022
| 'width="100.0" height="100.0" ' | ||
| 'viewBox="2.88 3.88 3.24 3.24" preserveAspectRatio="xMinYMin meet">' | ||
| '<g transform="matrix(1,0,0,-1,0,11.0)"><g>' | ||
| '<circle cx="6.0" cy="7.0" r="0.09720000000000001" ' |
There was a problem hiding this comment.
When I see something like that r value, I worry that it will be platform dependent. On a different system it might be "0.09720000000000002".
The most important thing might be to check that we have two circle elements and that their radii are roughly correct?
sgillies
requested changes
Feb 11, 2022
There was a problem hiding this comment.
@jreiberkyle these tests will help a lot! My only concern is that asserting on string representations of floats could be a bit flaky.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for
BaseGeometry._repr_svg_()in preparation for changes to the function in #1295.