Add geoms property to BaseGeometry #1965
Conversation
|
failing tests on seem to be tied to using |
There was a problem hiding this comment.
@cookiedan42 sorry for the delay in review! I have a suggestion that should unblock this work.
shapely/geometry/base.py
Outdated
|
|
||
| @property | ||
| def geoms(self): | ||
| return GeometrySequence(self) |
There was a problem hiding this comment.
@cookiedan42 here's what I suggest to solve the recursion issue. Do the following for the base class:
| return GeometrySequence(self) | |
| raise NotImplementedError |
And then for single-part Point, etc, classes, do this:
@property
def geoms(self):
return [self]GeometrySequence is nothing more than a Python sequence protocol backed by a GEOS multi-part geometry, but as you notice, introduces some complication.
|
@cookiedan42 I enabled the workflow. There are some linting issues and also this change really causes trouble for |
Added geoms property to BaseGeometry
Added tests for Simple Geometries to test .geom method
Resolves #1881