ci: Use git version of cross for better target support#3533
Open
OctopusET wants to merge 1 commit intosharkdp:masterfrom
Open
ci: Use git version of cross for better target support#3533OctopusET wants to merge 1 commit intosharkdp:masterfrom
OctopusET wants to merge 1 commit intosharkdp:masterfrom
Conversation
f599561 to
e813d97
Compare
Author
|
https://github.com/sharkdp/bat/actions/runs/20510747241/job/58931482644?pr=3532 after that it success |
This was referenced Dec 25, 2025
e813d97 to
1f9307d
Compare
Enselic
approved these changes
Feb 28, 2026
Collaborator
Enselic
left a comment
There was a problem hiding this comment.
LGTM but I'll wait a couple of days if other maintainers have concerns.
Enselic
requested changes
Feb 28, 2026
| uses: taiki-e/install-action@v2 | ||
| with: | ||
| tool: cross | ||
| run: cargo install cross --git https://github.com/cross-rs/cross |
Collaborator
There was a problem hiding this comment.
actually let's lock this to a specific SHA1, otherwise CI will be flaky
Author
There was a problem hiding this comment.
I will try to add the hash soon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
riscv64gc-unknown-linux-musl isn't released yet, and maintainer aims for more things for new release. So I don't think new release will be released soon.
cross-rs/cross#1664
cross-rs/cross#1718
Also, I think it's not easy to change version of taiki-e/install-action@v2 upstream.