Upgrade to bitvec 1.0.0#281
Merged
sharksforarms merged 3 commits intoNov 16, 2022
Merged
Conversation
Closed
|
Does the performance issue block this? I'm trying to use Deku in my experimental crate but suffering from the problem mentioned in #296. How can we help to push forward this PR? |
Owner
|
Looks like it's time to push towards bitvec 1.0.0, if we release this change as a major release version, clients will need to opt-in to the performance difference (although they may need to opt-in just tot be able to build again, unless they use an older deku). Related: #296 |
129a07a to
3bf34b6
Compare
Collaborator
Author
|
Agreed, hopefully we can figure out the performance later. |
c670de8 to
4ba1ff4
Compare
4ba1ff4 to
b4e480f
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-based #246 ontop of master, see previous conversation about decrease in performance for bitvec v1.0.0.
Perf: