Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support bool literal as enum id#472

Merged
wcampbell0x2a merged 1 commit into
masterfrom
470-support-bool-literal-as-enum-id
Sep 5, 2024
Merged

Support bool literal as enum id#472
wcampbell0x2a merged 1 commit into
masterfrom
470-support-bool-literal-as-enum-id

Conversation

@wcampbell0x2a
Copy link
Copy Markdown
Collaborator

Closes #471

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 2, 2024

Benchmark for 4a6185e

Click to view benchmark
Test Base PR %
deku_read_bits 1175.7±9.97ns 1189.9±18.61ns +1.21%
deku_read_byte 3.3±0.04ns 3.5±0.09ns +6.06%
deku_read_enum 2.5±0.04ns 2.8±0.06ns +12.00%
deku_read_vec 33.9±0.46ns 34.4±0.66ns +1.47%
deku_write_bits 174.0±2.33ns 180.5±4.11ns +3.74%
deku_write_byte 22.6±0.20ns 22.7±0.26ns +0.44%
deku_write_enum 21.8±0.46ns 21.7±0.38ns -0.46%
deku_write_vec 395.2±4.95ns 333.3±5.76ns -15.66%

sharksforarms
sharksforarms previously approved these changes Sep 3, 2024
Copy link
Copy Markdown
Owner

@sharksforarms sharksforarms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, pending some CI

@wcampbell0x2a wcampbell0x2a force-pushed the 470-support-bool-literal-as-enum-id branch from c22ec31 to 7810d9e Compare September 4, 2024 03:53
@wcampbell0x2a wcampbell0x2a changed the base branch from master to fix-ci September 4, 2024 03:53
@wcampbell0x2a wcampbell0x2a force-pushed the 470-support-bool-literal-as-enum-id branch from 7810d9e to fee7a6e Compare September 4, 2024 03:55
@wcampbell0x2a wcampbell0x2a added this to the 0.18.0 milestone Sep 4, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 4, 2024

Benchmark for 2247dc2

Click to view benchmark
Test Base PR %
count 3.4±0.02µs 3.6±0.02µs +5.88%
deku_read_bits 1130.5±13.92ns 1113.6±19.87ns -1.49%
deku_read_byte 3.6±0.26ns 3.4±0.09ns -5.56%
deku_read_enum 3.5±0.03ns 3.1±0.02ns -11.43%
deku_read_vec 31.6±0.47ns 31.0±0.42ns -1.90%
deku_write_bits 184.9±3.06ns 194.9±4.32ns +5.41%
deku_write_byte 24.6±0.59ns 24.6±0.22ns 0.00%
deku_write_enum 22.7±0.28ns 22.6±0.21ns -0.44%
deku_write_vec 436.3±5.57ns 431.6±5.11ns -1.08%
read_all 3.8±0.05µs 3.8±0.06µs 0.00%
read_all_bytes 5.6±0.03µs 5.5±0.02µs -1.79%

Base automatically changed from fix-ci to master September 4, 2024 12:28
An error occurred while trying to automatically change base from fix-ci to master September 4, 2024 12:28
@wcampbell0x2a wcampbell0x2a force-pushed the 470-support-bool-literal-as-enum-id branch from fee7a6e to eb5b668 Compare September 4, 2024 12:48
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 4, 2024

Benchmark for 1d9de89

Click to view benchmark
Test Base PR %
count 3.6±0.02µs 3.4±0.02µs -5.56%
deku_read_bits 1192.0±11.81ns 1130.2±20.57ns -5.18%
deku_read_byte 3.4±0.12ns 3.6±0.08ns +5.88%
deku_read_enum 3.1±0.03ns 3.5±0.05ns +12.90%
deku_read_vec 32.0±0.44ns 31.7±0.46ns -0.94%
deku_write_bits 206.2±10.76ns 207.7±6.17ns +0.73%
deku_write_byte 24.6±0.73ns 24.5±0.40ns -0.41%
deku_write_enum 22.6±0.23ns 22.7±0.34ns +0.44%
deku_write_vec 434.2±10.37ns 412.0±6.29ns -5.11%
read_all 3.8±0.03µs 3.8±0.07µs 0.00%
read_all_bytes 5.5±0.02µs 5.6±0.15µs +1.82%

sharksforarms
sharksforarms previously approved these changes Sep 4, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 4, 2024

Benchmark for 92fe6c7

Click to view benchmark
Test Base PR %
count 5.0±0.01µs 5.0±0.01µs 0.00%
deku_read_bits 1181.7±16.26ns 1184.7±17.26ns +0.25%
deku_read_byte 3.6±0.10ns 3.6±0.06ns 0.00%
deku_read_enum 3.5±0.03ns 3.5±0.15ns 0.00%
deku_read_vec 43.2±0.37ns 43.1±0.31ns -0.23%
deku_write_bits 199.1±3.50ns 191.7±4.38ns -3.72%
deku_write_byte 24.8±0.32ns 24.8±0.40ns 0.00%
deku_write_enum 23.4±0.52ns 23.5±0.79ns +0.43%
deku_write_vec 433.2±3.96ns 415.4±19.59ns -4.11%
read_all 3.8±0.11µs 3.8±0.07µs 0.00%
read_all_bytes 5.5±0.02µs 5.5±0.01µs 0.00%

@wcampbell0x2a wcampbell0x2a merged commit d0ca6a3 into master Sep 5, 2024
@wcampbell0x2a wcampbell0x2a deleted the 470-support-bool-literal-as-enum-id branch September 5, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support bool type in id attribute in Enum

2 participants