Add ByteSize impl for CString#497
Merged
Merged
Conversation
Collaborator
wcampbell0x2a
commented
Oct 31, 2024
- Use the new dynamic bytes attribute to apply to CString, which in many protocols you already have the size of the CString, so might as well use it
* Use the new dynamic bytes attribute to apply to CString, which in many protocols you already have the size of the CString, so might as well use it
Contributor
Benchmark for e130d8dClick to view benchmark
|
|
|
||
| #[should_panic(expected = "Incomplete(NeedSize { bits: 8 })")] | ||
| case(&[b't', b'e', b's', b't'], CString::new("test").unwrap(), &[]), | ||
| case(&[b't', b'e', b's', b't'], None, CString::new("test").unwrap(), &[]), |
Owner
There was a problem hiding this comment.
thought of a new test, what happens when no null byte is present
and, what happens when it's the correct len, but no nul byte present
Collaborator
Author
There was a problem hiding this comment.
Both of these are represented by 141cc5b
Contributor
Benchmark for c01eb5bClick to view benchmark
|
sharksforarms
approved these changes
Nov 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.