Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: cmd is compatible with node 22.10 #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025
Merged

fix: cmd is compatible with node 22.10 #1219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
node-version:
- 18
- 20
- '22.9.0'
- 22
os:
- ubuntu-latest
- macos-latest
Expand Down
3 changes: 2 additions & 1 deletion scripts/check-node-support.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ var MAX_NODE_VERSION = 22;
var pinnedNodeVersions = {
// Format:
// majorVersionInt: 'full.node.version',
22: '22.9.0',
// Example:
// 22: '22.9.0',
};

function checkReadme(minNodeVersion) {
Expand Down
9 changes: 8 additions & 1 deletion src/cmd.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,20 @@ common.register('cmd', _cmd, {
wrapOutput: true,
});

function isNullOrUndefined(val) {
return val === null || val === undefined;
}

function commandNotFound(execaResult) {
if (process.platform === 'win32') {
var str = 'is not recognized as an internal or external command';
return execaResult.code && execaResult.stderr.includes(str);
} else {
// On node <= 22.9.0, stdout/stderr are 'null'.
// On node >= 22.10, stdout/stderr are 'undefined'.
return execaResult.code &&
execaResult.stdout === null && execaResult.stderr === null;
isNullOrUndefined(execaResult.stdout) &&
isNullOrUndefined(execaResult.stderr);
}
}

Expand Down