chore(travis): add OS X to Travis CI #283
Conversation
|
It looks like travis doesn't fully support node on osx out of the box:
|
|
Yup, saw that as soon as I pushed. I'm going to try the steps here (travis-ci/travis-ci#2311 (comment)) |
|
@ariporad This should be ready for review now. Commits are squashed. This wound up being more changes to the yaml file than I anticipated. It should work very similarly to the previous behavior though. I followed the recommendation from this comment. I changed language to This makes things look a bit uglier in the yaml file, but perhaps the benefit of testing under os x is worth it. Also, does this follow the preferred convention for commit messages? |
| - NODE_VERSION="0.10" | ||
| - NODE_VERSION="0.11" | ||
| - NODE_VERSION="0.12" | ||
| - NODE_VERSION="4.2.4" |
There was a problem hiding this comment.
Two things:
- I'd say just change this to
4 - Can you add
5, and/orstable?
There was a problem hiding this comment.
I think it's at 4.2.4 because that's the latest LTS (@arturadib set that up). I'll add a more recent version as well though.
There was a problem hiding this comment.
@nfischer: I know, but change this from NODE_VERSION="4.2.4" to just NODE_VERSION="4". That way if they do a patch release it will automatically work.
There was a problem hiding this comment.
@ariporad Finally got around to fixing this. You're right, 4.x.x is a better move going forward. This should be good for review now.
|
@nfischer: I made a comment or two, but otherwise looks good. And the commit message is great! |
|
👍 |
|
@ariporad |
| - NODE_VERSION="0.11" | ||
| - NODE_VERSION="0.12" | ||
| - NODE_VERSION="4.2.4" | ||
| - NODE_VERSION="5.0" |
There was a problem hiding this comment.
This should just be 5 (The current version of node is 5.4.1, and that won't match 5.0.
There was a problem hiding this comment.
Ok, I can switch to 5. I wasn't sure if we always wanted to test against the latest release of node (could be somewhat unstable).
Change language to c++ to delay nvm commands until after nvm is installed. Install steps are explicit to make sure that Travis CI will always have the nvm package, even on OS X. Changing to Node v4.x.x
|
LGTM! |
chore(travis): add OS X to Travis CI
Just adding OS X to the CI, since this should be supported (and it was very easy to add). If this PR fails, then it'll point out some bugs that we have to track down.