Add newline to output of echo #557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@freitagbr Can you also add a test? |
|
@nfischer Sure. I am thinking however that the behavior of this should be changed. Currently, |
|
@freitagbr unix You raise a good point though, so I filed #557 |
|
Looks good. Let's wait until we ava-ify the tests for |
|
Ok. Is it worth adding support for |
|
You can do that in a new PR, it shouldn't necessarily be blocked by this. Either way, let's wait to get the |
|
@nfischer I rewrote the test for this branch. |
|
LGTM, make sure we land this on dev, not master. |
freitagbr
added a commit
that referenced
this pull request
Dec 7, 2016
* Add newline to output of echo * Add test
nfischer
pushed a commit
that referenced
this pull request
Dec 8, 2016
* Add newline to output of echo * Add test
nfischer
pushed a commit
that referenced
this pull request
Jan 17, 2017
* Add newline to output of echo * Add test
freitagbr
pushed a commit
that referenced
this pull request
Mar 16, 2017
* Add newline to output of echo (#557) * Add newline to output of echo * Add test * Throw an error if the options string does not start with '-' (#615) * Throw an error if the options string does not start with '-' * Add test * Change message grammar * Add -n option to echo * Fix null argument issue * Add -n tests * Add documentation * Add -en escaped character test * Add function to parse options for echo * Use parseOptions to parse echo options * Simplify control flow * parseOptions throws now * Allow null to be echoed * Prevent echo stderr on unrecognized option * Add test to check stderr of returned value * Use consistent variable name * Change test message, leave TODO about console output
freitagbr
added a commit
that referenced
this pull request
Jun 7, 2017
* Add newline to output of echo * Add test
freitagbr
pushed a commit
that referenced
this pull request
Jun 7, 2017
* Add newline to output of echo (#557) * Add newline to output of echo * Add test * Throw an error if the options string does not start with '-' (#615) * Throw an error if the options string does not start with '-' * Add test * Change message grammar * Add -n option to echo * Fix null argument issue * Add -n tests * Add documentation * Add -en escaped character test * Add function to parse options for echo * Use parseOptions to parse echo options * Simplify control flow * parseOptions throws now * Allow null to be echoed * Prevent echo stderr on unrecognized option * Add test to check stderr of returned value * Use consistent variable name * Change test message, leave TODO about console output
Merged
nfischer
pushed a commit
that referenced
this pull request
Jun 7, 2017
* Add newline to output of echo * Add test
nfischer
added a commit
that referenced
this pull request
Jun 7, 2017
* Add newline to output of echo (#557) * Add newline to output of echo * Add test * Throw an error if the options string does not start with '-' (#615) * Throw an error if the options string does not start with '-' * Add test * Change message grammar * Add -n option to echo * Fix null argument issue * Add -n tests * Add documentation * Add -en escaped character test * Add function to parse options for echo * Use parseOptions to parse echo options * Simplify control flow * parseOptions throws now * Allow null to be echoed * Prevent echo stderr on unrecognized option * Add test to check stderr of returned value * Use consistent variable name * Change test message, leave TODO about console output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #476