Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix(which): match only executable files (#657) #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 18, 2018
Merged

Fix(which): match only executable files (#657) #874

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
79b8feb
fix(which): match only executable files (#657)
termosa Jul 12, 2018
644e632
fix(which): replace constant to support earlier versions of NodeJS (#…
termosa Jul 12, 2018
9157b53
fix(which): address @nfischer comments (#657)
termosa Jul 14, 2018
ce70542
fix(which): use indexOf (#657)
termosa Jul 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(which): use indexOf (#657)
  • Loading branch information
@termosa
termosa committed Jul 15, 2018
commit ce705425948bae09095e1ee7eb007389dfc3ab6b
2 changes: 2 additions & 0 deletions src/which.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ function splitPath(p) {
return p ? p.split(path.delimiter) : [];
}

// Tests are running all cases for this func but it stays uncovered by codecov due to unknown reason
/* istanbul ignore next */
function isExecutable(pathName) {
try {
// TODO(node-support): replace with fs.constants.X_OK once remove support for node < v6
Expand Down
3 changes: 1 addition & 2 deletions test/which.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,7 @@ test('None executable files does not appear in the result list', t => {
t.truthy(resultForWhichA);
t.truthy(resultForWhichA.length);
t.not(resultForWhich.toString(), matchingFile);
// TODO(node-support): this can be used starting from node@6: t.falsy(resultForWhichA.includes(matchingFile))
t.not(resultForWhichA[0], matchingFile);
t.is(resultForWhichA.indexOf(matchingFile), -1);

process.env.PATH = pathEnv;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry, I must have missed this. This should go in an test.afterEach.always block. Example:

shelljs/test/exec.js

Lines 14 to 17 in 6d66a1a

test.afterEach.always(() => {
process.chdir(CWD);
shell.config.execPath = ORIG_EXEC_PATH;
});

This shouldn't block this change. I added a comment to #834 to track this.

});