Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix silent exec #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2018
Merged

Fix silent exec #892

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c368d56
fix: silent does not always work #851
Jun 23, 2018
5f3042d
Unconditionally silence error()
nfischer Oct 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Unconditionally silence error()
  • Loading branch information
@nfischer
nfischer committed Oct 10, 2018
commit 5f3042dbc1477aeb76ac3502a803a03c1bd503b5
5 changes: 4 additions & 1 deletion src/exec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,10 @@ function execSync(cmd, opts, pipe) {
try { common.unlinkSync(stdoutFile); } catch (e) {}

if (code !== 0) {
common.error(stderr, code, { continue: true, silent: opts.silent });
// Note: `silent` should be unconditionally true to avoid double-printing
// the command's stderr, and to avoid printing any stderr when the user has
// set `shell.config.silent`.
common.error(stderr, code, { continue: true, silent: true });
}
var obj = common.ShellString(stdout, stderr, code);
return obj;
Expand Down