Fix high memory usage (#173)#174
Closed
bew wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Based on webdeveric/webpack-assets-manifest#47 I simplified the implementation to be future-proof (effectively disabling everything by default instead of manually listing every field we don't want one by one). |
|
Not sure if the author still want to maintain this library. If not, there is another plugin webpack-assets-manifest that do exactly the same thing and they have this problem fixed in this commit already, but they haven't released it yet. Run |
Contributor
|
Hi @bew Could you fix the tests please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #173
The
toJson()call can use a lot of memory by generating a lot of stats information about modules.But we don't use this information for this plugin, so we can only enable the generation of assets related data used for this plugin.
Read #173 for more information