Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Plot line with nominal X axis values (--data-field-x-nominal) #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shenwei356 merged 2 commits into from
Mar 14, 2025
Merged

Plot line with nominal X axis values (--data-field-x-nominal) #308

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c09cc8
add support for nominal X values in line plot
lovromazgon Mar 13, 2025
f8aaaa0
don't allow ln scale for nominal values
lovromazgon Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 50 additions & 8 deletions csvtk/cmd/line.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import (
"fmt"
"os"
"runtime"
"slices"
"sort"
"strconv"
"strings"
Expand Down Expand Up @@ -115,6 +116,11 @@ Notes:
naMap[strings.ToLower(na)] = struct{}{}
}

nominal := getFlagBool(cmd, "data-field-x-nominal")
if nominal && plotConfig.scaleLnX {
checkError(fmt.Errorf("can't use --data-field-x-nominal and --x-scale-ln together"))
}

file := files[0]
headerRow, fields, data, _, _, err := parseCSVfile(cmd, config, file, plotConfig.fieldStr, false, true, false)

Expand All @@ -126,6 +132,21 @@ Notes:
checkError(err)
}

var xNominalValues []string
if nominal {
// Collect unique values
xNominalValues = make([]string, 0, len(data)/4) // Assume a quarter of the data is unique
for _, d := range data {
i, found := slices.BinarySearch(xNominalValues, d[0])
if !found {
// 0 alloc insert slice trick https://go.dev/wiki/SliceTricks#insert
xNominalValues = append(xNominalValues, "")
copy(xNominalValues[i+1:], xNominalValues[i:])
xNominalValues[i] = d[0]
}
}
}

// =======================================

groups := make(map[string]plotter.XYs)
Expand All @@ -134,20 +155,27 @@ Notes:
var ok bool
var order int
var groupName string

for _, d := range data {
if skipNA {
if _, ok = naMap[strings.ToLower(d[0])]; ok {
continue
}
}

x, err = strconv.ParseFloat(d[0], 64)
if err != nil {
if len(headerRow) > 0 {
checkError(fmt.Errorf("fail to parse X value: %s at column: %s. please choose the right column by flag --data-field-x", d[0], headerRow[0]))
} else {
checkError(fmt.Errorf("fail to parse X value: %s at column: %d. please choose the right column by flag --data-field-x", d[0], fields[0]))
if !nominal {
// X is considered a coordinate
x, err = strconv.ParseFloat(d[0], 64)
if err != nil {
if len(headerRow) > 0 {
checkError(fmt.Errorf("fail to parse X value: %s at column: %s. please choose the right column by flag --data-field-x or use --data-field-x-nominal", d[0], headerRow[0]))
} else {
checkError(fmt.Errorf("fail to parse X value: %s at column: %d. please choose the right column by flag --data-field-x or use --data-field-x-nominal", d[0], fields[0]))
}
}
} else {
// X is considered a nominal value
x = float64(slices.Index(xNominalValues, d[0]))
}
if len(d) > 1 {
if skipNA {
Expand Down Expand Up @@ -232,9 +260,9 @@ Notes:
i++
}
if lineWidth > pointSize {
p.Legend.Padding = vg.Length(lineWidth)
p.Legend.Padding = lineWidth
} else {
p.Legend.Padding = vg.Length(pointSize)
p.Legend.Padding = pointSize
}
p.Legend.Top = getFlagBool(cmd, "legend-top")
p.Legend.Left = getFlagBool(cmd, "legend-left")
Expand Down Expand Up @@ -275,6 +303,18 @@ Notes:
p.Y.Scale = plot.LogScale{}
p.Y.Tick.Marker = plot.LogTicks{Prec: -1}
}
if nominal {
p.X.Tick.Marker = plot.TickerFunc(func(min, max float64) []plot.Tick {
ticks := plot.DefaultTicks{}.Ticks(min, max)
for i, t := range ticks {
if t.Label == "" { // Skip minor ticks, they are fine.
continue
}
ticks[i].Label = xNominalValues[int(t.Value)]
}
return ticks
})
}

if plotConfig.xminStr != "" {
p.X.Min = plotConfig.xmin
Expand Down Expand Up @@ -317,4 +357,6 @@ func init() {
lineCmd.Flags().Float64P("line-width", "", 1.5, "line width")
lineCmd.Flags().Float64P("point-size", "", 3, "point size")
lineCmd.Flags().IntP("color-index", "", 1, `color index, 1-7`)

lineCmd.Flags().BoolP("data-field-x-nominal", "", false, `data field X is treated as a nominal field`)
}