Fix Issue #2442: Added support for Aparat #2459
Conversation
|
Welcome to open source! Appreciate this being one of your first contributions! There's one issue with this site, but I'll share a likely fix... |
| "errorType": "status_code", | ||
| "url": "https://www.aparat.com/{}/", | ||
| "urlMain": "https://www.aparat.com/", | ||
| "username_claimed": "jadi" |
There was a problem hiding this comment.
This returns true for all tested items (false positives).
The endpoint used always returns 200 or a 304 to a 200, even though there are 404s found in the stream elsewhere.
The API endpoint it uses in-stream does directly return a 404, however.
Additionally, status_code requests default to HEAD rather than GET, which the api endpoint doesn't like.
This should be resolved by adding the following items:
| "errorType": "status_code", | |
| "url": "https://www.aparat.com/{}/", | |
| "urlMain": "https://www.aparat.com/", | |
| "username_claimed": "jadi" | |
| "errorType": "status_code", | |
| "request_method": "GET", | |
| "url": "https://www.aparat.com/{}/", | |
| "urlMain": "https://www.aparat.com/", | |
| "urlProbe": "https://www.aparat.com/api/fa/v1/user/user/information/username/{}", | |
| "username_claimed": "jadi" |
There was a problem hiding this comment.
You can accept this directly by hitting the Commit suggestion button, or you can edit locally and push. Please ping when updated.
This adds support for https://www.aparat.com/
This is my first contribution to an open-source project, please give me any feedback you can.