feat: Conflict with older symfony/type-info versions which are not compatible with phpstan 2 #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which are not compatible with phpstan 2
shyim
approved these changes
Mar 19, 2025
|
hey @aragon999 would you mind updating this PR? or is it even still relevant? by now, we have separate composer.json files for each version with different shopware/core target versions. please use the one applicable for you |
|
@mitelg yes I think it is still required (not tested though), but I will have a look. But tbh. I am not sure if I understand the new structure. This constraint is needed for all 6.7.x versions, to which |
|
|
Yes, but this also covers several 6.6.x versions, for which this constraint is not needed, and may even lead to problems. |
|
I see 🤔 would this PR solve the problem? symfony/symfony#61020 I tested it here https://github.com/shopware/shopware/pull/10945/files#r2180125819 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/FriendsOfShopware/platform-plugin-dev-docker/actions/runs/13936156525/job/39004640133?pr=41#step:5:1242
And this comment: FriendsOfShopware/platform-plugin-dev-docker#41 (comment)
When I add the conflict to the
composer.jsoneverything works as expected: https://github.com/FriendsOfShopware/platform-plugin-dev-docker/actions/runs/13950779471/job/39049495464?pr=41#step:5:554But tbh I am not sure against which branch this PR should be targeted, as in the current trunk (version 6.7) the package in version 0.5.0 is required: https://github.com/shopware/shopware/blob/trunk/composer.json#L114