chore: Fix PHPStan execution on lowest dependencies #10945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mitelg
commented
Jul 2, 2025
mitelg
commented
Jul 2, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #10945 +/- ##
=======================================
Coverage 54.91% 54.92%
=======================================
Files 4785 4785
Lines 162756 162752 -4
Branches 8919 8919
=======================================
+ Hits 89382 89386 +4
+ Misses 70749 70741 -8
Partials 2625 2625
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mitelg
commented
Jul 2, 2025
282fee5 to
ea18c74
Compare
|
PHPStan on lowest deps run is green and now a nightly job https://github.com/shopware/shopware/actions/runs/16649433868/job/47117966953?pr=10945 |
ea18c74 to
0cef737
Compare
shyim
approved these changes
Jul 31, 2025
tobiasberge
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this change necessary?
If you execute
composer update --prefer-lowestand thencomposer phpstan, the execution fails2. What does this change do, exactly?
Increase the min version of some dependencies.
5. Checklist